Skip to content

src/goLanguageServer: enforce minimum version requirement even when checkForUpdates is off #1334

@hyangah

Description

@hyangah

There are cases where the backwards compatibility is not feasible (e.g. #1300).
Even though we have a minimum version hard-coded, currently the version check logic is completely skipped if users configured to use checkForUpdates : off.

if (tool.name !== 'gopls' || cfg.checkForUpdates === 'off' || IsInCloudIDE) {

Either enforce that, or clearly communicate with users about the risk.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions