-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscgo: retract the vscgo "module" #3420
Comments
Change https://go.dev/cl/591158 mentions this issue: |
Change https://go.dev/cl/591159 mentions this issue: |
Change https://go.dev/cl/591755 mentions this issue: |
@hyangah I missed the discussion why this is happening. Could you please point me to the discussion? The linked issue only seems to explain how to do depublish unintentionally published code, not why this tool is being retracted. |
@nightlyone Sorry that I omitted the detail. I just updated the issue description. Note: the tool is not getting retracted. We are retracting the module. Our intention is to move more extension's logic to the |
…scode-go/vscgo "module" Retract all versions including the version to tag For #3420 Change-Id: I4dd80bd14bf464b568e3ac867d5bcafecb1e250e Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/591755 TryBot-Bypass: Hyang-Ah Hana Kim <hyangah@gmail.com> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Suzy Mueller <suzmue@golang.org>
This is done. Still pkgsite doesn't display the doc due to license check failure, but that's a separate issue. |
Problem:
https://pkg.go.dev/github.com/golang/vscode-go/vscgo shows the old unversioned vscgo. Moreover,
go install github.com/golang/vscode-go/vscgo@latest
picks up an old version of vscgo.What happened?:
Before we restructured the repo struct and settled in the current shape , there was a brief period of time that we had a
go.mod
file under github.com/golang/vscode-go/vscgo directory (b01b0b7).In mid Jan, we moved the
vscgo
package to thegithub.com/golang/vscode-go
module, and moved the extension code to a separate module. #3122The following is the current state of this project
It's an oversight that we didn't retract the (short-lived) vscgo module during the transition.
It isn't an issue since the released extension always installs a specific version of vscgo like:
go install github.com/golang/vscode-go/vscgo@v0.41.3
In that case, the go command does the right thing.
Unfortunately, the short-lived vscgo module was already seen by the proxy.golang.org - https://proxy.golang.org/github.com/golang/vscode-go/vscgo/@latest which returns v0.0.0-20240105193802-b01b0b756e58
As a result, if someone runs
go install github.com/golang/vscode-go/vscgo@latest
with the default GOPROXY (proxy.golang.org), the go command will pick up this old copy
of the vscgo module and install the old version of vscgo tool.
pkg.go.dev also thinks currently there are two modules offering the vscgo package,
and prefers the old version. That is not what we want.
How to fix it:
We need to properly retract the github.com/golang/vscode-go/vscgo module.
Note: we still use the vscgo package (in github.com/golang/vscode-go module)
Follow the instruction in golang/go#67567 (comment)
Option 1)
v0.0.1-deprecated
and make sure it's seen by proxy.golang.org.--> Cons: this will create the unnecessary churn in the main branch.
Option 2)
vscgo-v0.0.1-deprecated
)--> Cons: we will need to create a temporary branch.
If the option 2 works, I think it is better (not leaving the trace in the main branch)
cc @suzmue
The text was updated successfully, but these errors were encountered: