Skip to content

envUtils.ts: log envFile load error #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

envUtils.ts: log envFile load error #2210

wants to merge 1 commit into from

Conversation

polinasok
Copy link
Contributor

This will turn ambiguous messages like this:
image
into this:
image

@gopherbot
Copy link
Collaborator

This PR (HEAD: 2a2ea1f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/401994 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1: Run-TryBot+1 Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/401994.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/538cd1b2-bec3-48ff-a34a-0d7350b239b9

Please don’t reply on this GitHub thread. Visit golang.org/cl/401994.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 25, 2022
@polinasok @gopherbot
envUtils.ts: log envFile load error
f4ccfc9 
This will turn ambiguous messages like this:
<img width="269" alt="image" src="https://user-images.githubusercontent.com/51177946/164947223-a890fbfc-2658-4a6a-88bc-c3e27908cd4b.png">
into this:
<img width="266" alt="image" src="https://user-images.githubusercontent.com/51177946/164947521-57f8ed07-e3ca-4bd5-b2cd-28e2e40e2121.png">

Change-Id: Ic8c3edc6fea9488e92d293826cefef6bcb018582
GitHub-Last-Rev: 2a2ea1f
GitHub-Pull-Request: #2210
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/401994
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/401994 has been merged.

@gopherbot gopherbot closed this Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polinasok @gopherbot