Skip to content

Conversation

eliben
Copy link
Member

@eliben eliben commented Jun 15, 2020

The documentation for launching a debug adapter (https://github.com/golang/vscode-go/blob/master/docs/debug-adapter.md) says "Choose the Launch as server" debug configuration.

However, the launch.json in the debugAdapter dir names this configuration "debug-debugger".

Fix the configuration name to be consistent with documentation, and with other launch.json files (the root launch.json also has this configuration named "Launch as server").

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jun 15, 2020
@gopherbot
Copy link
Collaborator

This PR (HEAD: 87950df) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/237917 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/237917.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jun 15, 2020
…launch.json

The documentation for launching a debug adapter (https://github.com/golang/vscode-go/blob/master/docs/debug-adapter.md) says "Choose the Launch as server" debug configuration.

However, the launch.json in the debugAdapter dir names this configuration "debug-debugger".

Fix the configuration name to be consistent with documentation, and with other launch.json files (the root launch.json also has this configuration named "Launch as server").

Change-Id: Ic0734174956a9907e16a74c42efced8ab17f43bb
GitHub-Last-Rev: 87950df
GitHub-Pull-Request: #224
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/237917
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/237917 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants