Skip to content

snippets: avoid using "var" as default name in snippets #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

snippets: avoid using "var" as default name in snippets #970

wants to merge 1 commit into from

Conversation

RomanKornev
Copy link
Contributor

@RomanKornev RomanKornev commented Nov 27, 2020 •
edited by hyangah
Loading

"var" is a reserved keyword. Some snippets using "var" as the default name produce Error: "expected 1 expression"
Replace the usage with more general names like v

Fixes #969

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 27, 2020
@gopherbot
Copy link
Collaborator

This PR (HEAD: 835feb4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/273746 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@hyangah hyangah changed the title fix #969: error using snippets with "var" as default name snippets: error using snippets with "var" as default name Nov 30, 2020
@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1: Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/273746.
After addressing review feedback, remember to publish your drafts!

@hyangah
Copy link
Contributor

hyangah commented Nov 30, 2020

I updated the PR comment and the title to follow Go project's commit message style guide line. The PR title and the very first comment are used by the commit message when merged.

Thanks for the fix!

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 2: Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/273746.
After addressing review feedback, remember to publish your drafts!

@hyangah hyangah changed the title snippets: error using snippets with "var" as default name snippets: avoid using "var" as default name in snippets Nov 30, 2020
gopherbot pushed a commit that referenced this pull request Nov 30, 2020
@RomanKornev @hyangah
snippets: avoid using "var" as default name in snippets
e8d462e 
"var" is a reserved keyword. Some snippets using "var" as the default name produce Error: "expected 1 expression"
Replace the usage with more general names like `v`

Fixes #969

Change-Id: If335db938715a7c79e72e7e4d2fd0dc87507ca1d
GitHub-Last-Rev: 835feb4
GitHub-Pull-Request: #970
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/273746
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Suzy Mueller <suzmue@golang.org>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopherbot pushed a commit that referenced this pull request Dec 8, 2020
@RomanKornev @hyangah
[release] snippets: avoid using "var" as default name in snippets
ffb1bae 
"var" is a reserved keyword. Some snippets using "var" as the default name produce Error: "expected 1 expression"
Replace the usage with more general names like `v`

Fixes #969

Change-Id: If335db938715a7c79e72e7e4d2fd0dc87507ca1d
GitHub-Last-Rev: 835feb4
GitHub-Pull-Request: #970
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/273746
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Suzy Mueller <suzmue@golang.org>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
(cherry picked from commit e8d462e)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/276213
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
@RomanKornev
Copy link
Contributor Author

Can confirm it's fixed in the latest release. Thanks everyone!

@RomanKornev RomanKornev closed this Dec 9, 2020
@RomanKornev RomanKornev deleted the patch-1 branch December 9, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error using snippets with "var" as default name

3 participants

@RomanKornev @gopherbot @hyangah