Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(version): Support for patch version #101

Merged
merged 1 commit into from
Oct 17, 2020
Merged

feat(version): Support for patch version #101

merged 1 commit into from
Oct 17, 2020

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Oct 3, 2020 •
edited
Loading

This commit is to support X.Y.Z version in config.

  • if X.Y.Z version is passed, honour it 👍
  • if X.Y version is passed, keep the same behaviour as it is right now.

Closes #98

@sayboras sayboras added hacktoberfest Label for hacktoberfest hacktoberfest-accepted hacktoberfest PR labels Oct 3, 2020
@sayboras sayboras changed the title feat(version): Support for patch verison feat(version): Support for patch version Oct 12, 2020
@sayboras sayboras marked this pull request as ready for review October 12, 2020 05:56
@sayboras sayboras requested review from a team October 12, 2020 05:58
@sayboras
feat(version): Support for patch verison
c8061f5 
This commit is to support X.Y.Z version in config.

- if X.Y.Z version is passed, honour it 👍
- if X.Y version is passed, keep the same behaviour
as it is right now.

Closes #98

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@lukasmalkmus
Copy link
Contributor

Can someone review and merge this so I can do #106?

@ernado
Copy link
Member

ernado commented Oct 16, 2020

Will take a look soon.

Nivl
Nivl approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@Nivl Nivl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

daixiang0
daixiang0 approved these changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sayboras sayboras added the enhancement New feature or request label Oct 17, 2020
bombsimon
bombsimon approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@daixiang0 daixiang0 merged commit a1c5369 into golangci:master Oct 17, 2020
@sayboras sayboras deleted the feature/patch-version branch October 17, 2020 08:54
zikaeroh added a commit to zikaeroh/golangci-lint-action that referenced this pull request Feb 21, 2021
@zikaeroh
Update "version" config in README example
cd12e7c 
golangci#98 was closed by golangci#101, but the README still says that only a major-minor version is accepted. It also says that this field is required, but `action.yml` says otherwise. Copy the description from `action.yml` into the README for consistency.
@zikaeroh zikaeroh mentioned this pull request Feb 21, 2021
Merged
SVilgelm pushed a commit that referenced this pull request Feb 23, 2021
@zikaeroh
Update "version" config in README example (#167)
23487cb 
#98 was closed by #101, but the README still says that only a major-minor version is accepted. It also says that this field is required, but `action.yml` says otherwise. Copy the description from `action.yml` into the README for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daixiang0 daixiang0 daixiang0 approved these changes

@bombsimon bombsimon bombsimon approved these changes

@Nivl Nivl Nivl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest Label for hacktoberfest hacktoberfest-accepted hacktoberfest PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support golangci-lint patch version
6 participants
@sayboras @lukasmalkmus @ernado @Nivl @bombsimon @daixiang0