Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated linters from presets #3405

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Dec 7, 2022

Fixes #3404

Related to #1987

@ldez ldez added enhancement New feature or improvement area: presets labels Dec 7, 2022
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this but I'm a bit surprised since we've generally been very cautious about changing any behaviour in the default preset, even regarding deprecated linters. This makes me thing of

xkcd

However I really hope people relying on this behaviour use an explicit config and like I said I'm all for any change making golangci-lint move faster!

@ldez ldez merged commit 67d57f4 into golangci:master Dec 8, 2022
@ldez ldez deleted the feat/remove-deprecated-linters-presets branch December 8, 2022 00:14
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez ldez added this to the v1.51 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: presets enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Official presets should not contain deprecated linters
2 participants