Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump github.com/go-critic/go-critic from 0.6.7 to 0.7.0 #3701

Merged
merged 5 commits into from
Mar 17, 2023
Merged

build(deps): bump github.com/go-critic/go-critic from 0.6.7 to 0.7.0 #3701

merged 5 commits into from
Mar 17, 2023

Conversation

cristaloleg
Copy link
Contributor

@cristaloleg cristaloleg commented Mar 17, 2023 •
edited by ldez

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 17, 2023

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@ldez ldez changed the title bump gocritic build(deps): bump https://github.com/go-critic/go-critic from 0.6.7 to 0.7.0 Mar 17, 2023
@ldez ldez added dependencies Relates to an upstream dependency linter: update version Update version of linter go Pull requests that update Go code labels Mar 17, 2023
@ldez ldez changed the title build(deps): bump https://github.com/go-critic/go-critic from 0.6.7 to 0.7.0 build(deps): bump github.com/go-critic/go-critic from 0.6.7 to 0.7.0 Mar 17, 2023
@cristaloleg
Copy link
Contributor Author

Error: An error occurred: [503 Service Unavailable] error accessing OSS Index

I think I cannot do much here.

BTW, to get rid of 3rd party deps I've switched to the official Go team tool govulncheck. Example CI https://github.com/cristalhq/.github/blob/main/.github/workflows/vuln.yml

@ldez
Copy link
Member

ldez commented Mar 17, 2023

I handle the problem with the vulnerability check

@cristaloleg cristaloleg marked this pull request as ready for review March 17, 2023 09:53
@ldez ldez self-requested a review March 17, 2023 10:30
ldez
ldez approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit e27b129 into golangci:master Mar 17, 2023
@cristaloleg cristaloleg deleted the bump-gocritic-0.7.0 branch March 17, 2023 17:07
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@cristaloleg @SeigeC
build(deps): bump github.com/go-critic/go-critic from 0.6.7 to 0.7.0 (g…
f766586 
…olangci#3701)
@ldez ldez added this to the v1.52 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Milestone
v1.52
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cristaloleg @CLAassistant @ldez