feat: add modernize analyzer suite #6126
Merged
+3,873
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
feat/modernize
branch
2 times, most recently
from
6067bf6 to
b9b3d11
Compare
bombsimon
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
Dang, that's a lot of test cases, nice! ⭐
I noticed there's 100 comments saying nope and 24 saying noop (x2 for the fixed version). Is this intentional? I guess noop would make more sense since there's no operation from any analyzer in those scenarios.
Also super nit, but there's a mix between Nope., nope: and nope, prefixed lines where we don't expect any diagnostic.
Of course, none of this is something I would block on and the clarification to why they don't have any diagnostic is what matters!
|
The test files are from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6123
Related to #686