Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax visibility of arraylist items / ability to addAll efficiently #19

Closed
phraktle opened this issue Jan 27, 2015 · 1 comment
Closed

Comments

@phraktle
Copy link

If one wants to append a IntArrayList to another IntArrayList, there's an extra copy involved due to the call to toArray():

   public boolean addAll(IntIterable source)
    {
        return this.addAll(source.toArray());
    }

Also, please relax the visibility of items to protected, so one can subclass this collection. As I understand, that was the design rationale for FastList vs. JDK ArrayList, but looks like the same mistake is repeated here :)

@goldmansachs
Copy link
Collaborator

Thanks for reporting this. We'll pick this up in the next minor release.

goldmansachs pushed a commit that referenced this issue Mar 13, 2015
…19.

git-svn-id: svn+ssh://gscollections.svn.services.gs.com/svnroot/gscollections-svn/trunk@816 d5c9223b-1aff-41ac-aadd-f810b4a99ac4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant