Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event controller #16

Merged
merged 3 commits into from
Feb 25, 2020
Merged

Event controller #16

merged 3 commits into from
Feb 25, 2020

Conversation

goldst
Copy link
Owner

@goldst goldst commented Feb 25, 2020

No description provided.

@todo
Copy link

todo bot commented Feb 25, 2020

this documentation is totally outdated. data isn't correct

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/blocks/card/CardAbstract.js#L34-L39


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

delete EventControlElements of elements that where removed

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/eventControl/EventController.js#L9-L14


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

Find out what exacly onlyNewElements does and add docs. If it

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/eventControl/EventController.js#L24-L29


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

add more specific classes in child classes of this classes

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/eventControl/EventController.js#L48-L53


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

remove transformOrigin and make modification funtions use that directly

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/eventControl/EventController.js#L248-L253


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

X, Y, Z, XY, XYZ throw if t=0. Explain in documentation.

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/Point4d.js#L5-L10


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

didn't test ES6 version yet. test.

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/Point4d.js#L251-L256


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

finish example. How to dom elements in Node.js could be done

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/PostTransformFunctions.js#L22-L27


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

Function only supports matrices. Add other types.

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/TransformableElement.js#L121-L126


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

I don't like the ' + Math.PI' in the loop because there is

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/TransformableElement.js#L161-L166


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

still some issues with high translate values (test case:

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/TransformableElement.js#L164-L169


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

How ugly! Needs a loop. But is a loop possible without

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/TransformableElement.js#L529-L534


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

might be better with loop. see _surroundingAscents().

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/TransformableElement.js#L548-L553


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

returns center of element ATM. change it to the origin.

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/TransformableElement.js#L621-L626


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

delete TransformableElements of elements that where removed

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/TransformationController.js#L10-L15


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

Find out what exacly onlyNewElements does and add docs. If it

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/TransformationController.js#L23-L28


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@goldst goldst closed this Feb 25, 2020
@goldst goldst reopened this Feb 25, 2020
@todo
Copy link

todo bot commented Feb 25, 2020

this documentation is totally outdated. data isn't correct

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/blocks/card/CardAbstract.js#L34-L39


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

X, Y, Z, XY, XYZ throw if t=0. Explain in documentation.

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/Point4d.js#L5-L10


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

didn't test ES6 version yet. test.

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/Point4d.js#L251-L256


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

where is this used, why is this necessary, what does this override?

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/TransformableElement.js#L25-L30


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

@todo
Copy link

todo bot commented Feb 25, 2020

I don't like the ' + Math.PI' in the loop because there is

https://github.com/goldst/ein-web/blob/011451ddba9bab4b862b54d58fd4fb39f4b005d0/js/transformationNew/TransformableElement.js#L165-L170


This comment was generated by todo based on a todo comment in 011451d in #16. cc @goldst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant