Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market decentralized - broadcast offers #290

Merged
merged 31 commits into from
Jun 9, 2020
Merged

Market decentralized - broadcast offers #290

merged 31 commits into from
Jun 9, 2020

Conversation

nieznanysprawiciel
Copy link
Contributor

@nieznanysprawiciel nieznanysprawiciel commented May 29, 2020 •
edited
Loading

Implements task #296
PR based on #269, that should be merged first.

  • Broadcast offer to all connected nodes
    • All nodes that received broadcast, will broadcast it to neighbors
    • Broadcast is not forwarded, if Offer already existed in database on Node
    • Fix in BCastService - create topic on centralized hub
  • Fix unsubscribe Offer/Demand http response. Market api expected string result.
  • Refactor

nieznanysprawiciel and others added 23 commits May 26, 2020 18:49
@nieznanysprawiciel @tworec
Add database most important tables
b1662df
@nieznanysprawiciel @tworec
Insert offer to database
de3be45
@nieznanysprawiciel @tworec
[Test] Check market state after subscribing offer
9809678
@nieznanysprawiciel @tworec
Unsubscribe offer
6d5bbe7
@nieznanysprawiciel @tworec
[Test] Add check on not existing subsctiption id
dfe14a0
@nieznanysprawiciel @tworec
Subscribe demand and unsubscribe [+Test]
bf4d731
@nieznanysprawiciel @tworec
Add http endpoints
98c189d
@nieznanysprawiciel @tworec
Decentralized market running instruction
2701327
@nieznanysprawiciel @tworec
SubscriptionId consists of random part and offer/demand hash
fd6c148
@tworec
rebased on service-ctx-sep-dbs
30edee1
@nieznanysprawiciel
Add timestamps to Offer/Demand
723b88b
@nieznanysprawiciel
Merge branch 'master' of github.com:golemfactory/yagna into market-de…
84577c1 
…centralized/db-models
@nieznanysprawiciel
Cargo fmt
7616d77
@nieznanysprawiciel
Try to bind to broadcast
fddb607
@nieznanysprawiciel
Merge branch 'market-decentralized/db-models' of github.com:golemfact…
3c2785a 
…ory/yagna into market-decentralized/broadcast-offers
@nieznanysprawiciel
Binding to broadcast works in test
873faa1
@nieznanysprawiciel
Broadcasting offers. Receiving Offers fast implementation just to che…
1c2dfeb 
…ck - still doesn't work
@nieznanysprawiciel
Get rid of dyn Discovery. Trait is not needed anymore, since we can m…
846fb72 
…ock on net level
@nieznanysprawiciel
Stop Offer propagation if it already existed in db or error occured
ef64faa
@nieznanysprawiciel
[Docs] Describe how to use logger with test suite
3d32078
@nieznanysprawiciel
Fix: BCastService returns correct value if topic is new
d1718d6
@nieznanysprawiciel
Broadcasting Offers works with yagna service
6e1a7ce
@nieznanysprawiciel
Fix unsubscribe Offer/Demand http response
cfac41a
@nieznanysprawiciel nieznanysprawiciel marked this pull request as ready for review June 1, 2020 11:53
@nieznanysprawiciel
Copy link
Contributor Author

TODO: Merge master after #269 will be merged into master

@tworec tworec changed the base branch from master to market-decentralized/db-models June 2, 2020 19:59
tworec
tworec suggested changes Jun 2, 2020
View reviewed changes
core/market/decentralized/readme.md Show resolved Hide resolved
core/market/decentralized/src/api/provider.rs Outdated Show resolved Hide resolved
core/market/decentralized/src/market.rs Outdated Show resolved Hide resolved
core/market/decentralized/src/matcher/matcher.rs Outdated Show resolved Hide resolved
core/market/decentralized/src/matcher/matcher.rs Outdated Show resolved Hide resolved
core/market/decentralized/src/protocol/discovery.rs Show resolved Hide resolved
core/market/decentralized/src/api/provider.rs Outdated Show resolved Hide resolved
core/market/decentralized/tests/test_offer_broadcast.rs Outdated Show resolved Hide resolved
core/market/decentralized/tests/test_offer_broadcast.rs Outdated Show resolved Hide resolved
core/market/decentralized/tests/utils/mock_net.rs Show resolved Hide resolved
tworec
tworec reviewed Jun 4, 2020
View reviewed changes
Copy link
Contributor

@tworec tworec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review finished, no more comments

@nieznanysprawiciel nieznanysprawiciel linked an issue Jun 4, 2020 that may be closed by this pull request
Network Offer Discovery #296
Closed
3 tasks
@nieznanysprawiciel nieznanysprawiciel changed the base branch from market-decentralized/db-models to master June 4, 2020 16:34
@tworec tworec merged commit ad92480 into master Jun 9, 2020
@tworec tworec deleted the market-decentralized/broadcast-offers branch June 9, 2020 09:34
@tworec tworec mentioned this pull request Jul 9, 2020
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tworec tworec tworec approved these changes

@jiivan jiivan Awaiting requested review from jiivan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network Offer Discovery
2 participants
@nieznanysprawiciel @tworec