Add CI workflow to build and publish images #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pins to a specific version of xk6 in the Makefile so that builds are reproducible. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Adds an xk6-coap Dockerfile that builds a k6 distribution with xk6-coap and includes it in a minimal distroless image. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Adds a CI workflow that validates building and publishing xk6-coap images. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
hasheddan
force-pushed
the
feat/img-build
branch
from
d6fafc5
to
7b28738
Compare
Updates README.md to inform how to run with the goliothiot/xk6-coap image. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
tim-golioth
approved these changes
Jun 30, 2023
| username: goliothiot | ||
| password: ${{ secrets.DOCKER_TOKEN }} | ||
|
|
||
| - name: Build and Push to Dockerhub |
There was a problem hiding this comment.
what's the different between the Build and Export to Docker step above and this one?
There was a problem hiding this comment.
Good question! The build will just build the image and load it into Docker. We want to validate this on PRs and commits that aren't on main. On main we want to build and then push it, so this second "Build and Push" step will find the image we previously built and know it doesn't need to rebuild, then will push it to DockerHub 👍🏻
There was a problem hiding this comment.
Oh, so the Build and Export to Docker step above is just validating that the image can be built, i.e. nothing breaks in the Dockerfile. Makes more sense now! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CI workflow that validates building and publishing xk6-coap
images.
Signed-off-by: Daniel Mangum georgedanielmangum@gmail.com
Fixes #2
Fixes #3