Thread contexts down the stack

[arschles]

Ref: #170 (comment)

This also greatly helps us with tracing. cc/ @bketelsen

Here's an example on how to add a tracing span to a function:

func foo(ctx context.Context) {
    sp, ctx := buffet.ChildSpan("storage.save",context)
    defer sp.Close()
    // do stuff with ctx

[arschles]

Definitely don't have to do this all in one PR. That would be a big refactor!

[ghost]

I'm thinking if we start with just threading the context, not adding tracing as well, it should be pretty easy. Start in each app and only change one interface per PR.

[bketelsen]

that's a nice logical way to do this 👍

[tbpg]

I'll work on storage.Lister. A couple notes for anyone else who's working on updating an interface:

• You can search for interface implementations using grep -R -E 'func \(.+ List\(' . (you may want to restrict to pkg to avoid the vendor directory).
• Alternatively, update the interface, run go build ./..., and see what breaks. 😛

[arschles]

Rad! I’m a big fan of the second one but guess who’s gonna do some grepping tonight? This guy 😂

…

On Mon, Jul 23, 2018 at 12:06 Tyler Bui-Palsulich ***@***.***> wrote: I'll work on storage.Lister. A couple notes for anyone else who's working on updating an interface: - You can search for interface implementations using grep -R -E 'func \(.+ List\(' . (you may want to restrict to pkg to avoid the vendor directory). - Alternatively, update the interface, run go build ./..., and see what breaks. 😛 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#174 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEU0Qjr0MUGZW_YArfEBlfxY4Cwj0Quks5uJh7NgaJpZM4UooJt> .

[manugupt1]

#346

The above PR fixes it!

[manugupt1]

Ref: #392

[arschles]

@manugupt1 since #346 is done, do you think we can close this issue?

[manugupt1]

Yep! Threading context is done! Next steps are to do tracing which I think we have another issue for. Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Aaron Schlesinger <notifications@github.com> Sent: Wednesday, August 8, 2018 7:52:30 PM To: gomods/athens Cc: Manu Gupta; Mention Subject: Re: [gomods/athens] Thread contexts down the stack (#174) @manugupt1<https://github.com/manugupt1> since #346<#346> is done, do you think we can close this issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#174 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAYLj0qShdrHyOOcQWilZHysgCS9eDvTks5uO3m9gaJpZM4UooJt>.