Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release v2.0.1 #21

Closed
kron4eg opened this issue Aug 6, 2019 · 3 comments
Closed

Please release v2.0.1 #21

kron4eg opened this issue Aug 6, 2019 · 3 comments

Comments

@kron4eg
Copy link

kron4eg commented Aug 6, 2019

By looking at e8422f0 It seems like you've moved v2.0.0 tag, which is very unfortunate and should be avoided.

The problem is that proxy.golang.org already captured original v2.0.0 tag so now we have a situation when having
GOPROXY=https://proxy.golang.org gomods get lHNQverf0+Gm1TbSbVIDWVXOhZ2FpZopxRqpr2uIjs4= hash of the module
and with GOPROXY=direct gomods getting OyHbl+7IOECpPKfVK42oFr6N7+Y2dR+Jsb/IiDV3hOo=.

To resolve the situation please tag v2.0.1, and please never ever move tags between commits.

Example of affected go.sum file: kubernetes-sigs/cluster-api#1217

@tamalsaha
Copy link

I have applied v2.0.1 tag. Please check. Sorry about the inconvenience. I am still learning about go mod.

xref: kubernetes/test-infra#13918

Please reopen if there are new issues.

@fejta
Copy link

fejta commented Aug 22, 2019

Thanks so much!

@kron4eg
Copy link
Author

kron4eg commented Aug 22, 2019

Can confirm, for the v2.0.1 now hash is the same using GOPROXY=direct or GOPROXY=https://proxy.golang.org. Back to normal! Thanks.

teddyking added a commit to vmware-tanzu/projects-operator that referenced this issue Sep 19, 2019
Seems like something went terribly wrong and the author of
gomodules/jsonpatch moved a tag from one commit to another. This broker
everything (see info in:
gomodules/jsonpatch#21).

As a result, and because of the advice in this issue:
kubernetes-sigs/kubebuilder#997 we have bumped
our controller-runtime dependency to resolve the issue.

This seemed to work. Also bumped the go version in go.mod.

Co-authored-by: James Myers <jmyers@pivotal.io>
adrianludwin added a commit to adrianludwin/multi-tenancy that referenced this issue Sep 23, 2019
Explicitly updates versions of controller-runtime, ginkgo and gomega.
Also updates jsonpatch to 2.0.1 (cf
gomodules/jsonpatch#21).

Tested: `make test` works
philandstuff added a commit to alphagov/gsp that referenced this issue Nov 19, 2019
This pins jsonpatch to v2.0.1, because version v2.0.0 was yanked and
republished :( gomodules/jsonpatch#21

This also runs `go mod tidy` to remove some unused old dependencies.
philandstuff added a commit to alphagov/gsp that referenced this issue Nov 19, 2019
This pins jsonpatch to v2.0.1, because version v2.0.0 was yanked and
republished :( gomodules/jsonpatch#21

This also runs `go mod tidy` to remove some unused old dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants