-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dimmer-command-hook: wrong-number-of-arguments ... when alert package is used #6
Comments
Hmm. Can you please post the version of dimmer and which build of emacs? |
Using the current Homebrew version of Mituharu's (by way of Railwaycat) build:
Dimmer version: |
The code never actually calls Do you mind testing with no other packages enabled, i.e. something like
|
Ok, well folks on |
On a hunch, can you try evaluating each of the following in the
thanks. |
Giving the fresh cask env a try now. |
Works just fine with a fresh env. I think you're right: must be an interaction with another package in my config. I'll poke around and see if I can track it down. |
...would you let me know if you figure out which package? At least I can add that information to the readme. Thanks! |
@gonewest818 Disabling the Alert package fixes it for me. https://github.com/jwiegley/alert Not sure what the interaction is here, but simply running |
Ok, thank you for finding that. Looks like I can reproduce the error here... |
Ok, I found it.
So the wrong-number-of-arguments is where I'm computing the adjusted rgb value, and I've got a nil instead of a list of r, g, b. That should be easy to detect (and ignore), and I should be more careful about bad colors anyway. I'll also open a ticket with the other project. In the meantime, you could override that face to be "Dark Violet" which is presumably what he meant... This works for me:
|
When we call `color-name-to-rgb` we now catch the case where the color cannot be properly converted. This occurs when the color is specified by a name rather than a hex value, but the name isn't known to emacs. In that situation we ignore that face and don't try to dim it.
Thanks! |
I just pushed a fix to master. When the new build appears on MELPA, grab it and let me know if you see any further interactions with alert. Thanks for the bug report! |
I'm getting:
Error in post-command-hook (dimmer-command-hook): (wrong-number-of-arguments (3 . 3) 0)
Any ideas? What can I provide to be helpful?
[edit: debugging revealed what appears to be an interaction with the Alert
package ... so I'm renaming the issue accordingly -- Neil]
The text was updated successfully, but these errors were encountered: