-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
sort.Float64sAreSorted? |
This would allow testing for strict monotonicity, for what it's worth. This approach would also be faster than sort.IsSorted. This kind of thing doesn't really come up for me though so I don't know how useful it would be. |
The need to check for strictly increasing data came up for me this morning when working with some time series stuff. I'd added a basic version in the project I was working on and then thought I'd toss a more generic one into this repo in case it would be useful. |
I've never needed a test for strict monotonicity, though of course that doesn't mean it's not useful. I'm not just not sure we want to be duplicating standard library functionality. It would be a bit slower, but would it be more useful to add a
At the very least, we need to be careful with the English in the description because of NaN (or add more text). |
I would expect it to be |
Good points about duplicating functionality and the NaN issue. I originally had |
What is the decision here? |
The |
|
I'm still not sold on |
I'm happy to scrap |
I think a new PR would be better, although we're in the process of trying to merge all the repos together, so if it's not super time critical, maybe it can be one of the first PRs in the new combined repo? |
Makes sense. I'll close this one out then. |
No description provided.