This repository was archived by the owner on Nov 24, 2018. It is now read-only.
Add cgo and lapack64 functions for performing a QR and LQ solve from … #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test for Dormlq is disabled because I believe there is a bug in the c interface. Line 56 of http://www.netlib.org/lapack/explore-html/d1/de6/lapacke__dormlq__work_8c_source.html tests that the stride of a is greater than m. However, the number of columns of A depends on the Side, so the test should compare against m or n. See our check on lines 34 to 44 of lapack/native/Dorml2. Could you confirm or refute my suspicions @kortschak ? |
|
I agree.
|
|
OpenBLAS bug submitted at OpenMathLib/OpenBLAS#615 (comment) |
|
Lapack bug submitted but it is under moderation. |
|
PTAL @kortschak |
cgo/lapack.go
Outdated
|
LGTM with minor comments. |
…the factorization
btracey
added a commit
that referenced
this pull request
Aug 11, 2015
Add cgo and lapack64 functions for performing a QR and LQ solve from …
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the factorization