This repository was archived by the owner on Nov 23, 2018. It is now read-only.
Stop modifying Location beyond requested evaluations #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interfaces.go
Outdated
There was a problem hiding this comment.
"fields of Problem" instead of routine? Not sure.
|
I hope you don't mind I took the liberty to take a second pass at a lot of the existing comments. Otherwise, two seemingly small issues. LGTM assuming the issues aren't trickier than I think. |
vladimir-ch
force-pushed
the
stop-invalidating
branch
from
b3a0eb5 to
573e309
Compare
Not at all, quite the opposite. In fact, could you give it another, quick pass? I mostly went with your wording, but I also added the NaNing of f and projGrad given to the Linesearcher. |
There was a problem hiding this comment.
Sounds good, we'll leave to another PR for fix.
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evaluate()LinesearchMethod.locand instead gradually build up a valid location from the passedLocation. This avoids a lot of unnecessary copying and results in simpler code. It is a horribly crude benchmark, but on my machinego testfinishes regularly in 7.8-7.9 s with this change which is roughly 0.5 s faster than before.@btracey Please take a look