This repository was archived by the owner on Nov 23, 2018. It is now read-only.
Clean up LBFGS #152
Merged
Clean up LBFGS #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbfgs.go
Outdated
There was a problem hiding this comment.
why method instead of algorithm?
There was a problem hiding this comment.
Just for consistency with the other optimizers which all use the word "method".
|
LGTM |
vladimir-ch
force-pushed
the
cleanup-lbfgs
branch
3 times, most recently
from
7666852 to
3ba7cb6
Compare
vladimir-ch
force-pushed
the
cleanup-lbfgs
branch
from
3ba7cb6 to
04f4d20
Compare
|
@btracey Could you please take one last look? I changed the LBFGS comment and I deleted the tradeoff comment. I considered deleting the word "spatially" because from the point of view of LBFGS there is no other than spatial variation but in the end I left it there. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@btracey PTAL