This repository was archived by the owner on Nov 23, 2018. It is now read-only.
Simplify findLinearlyIndependent #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @vladimir-ch @sbinet |
convex/lp/simplex.go
Outdated
| // This is what needs to be changed if zero columns are allowed, as | ||
| // a column of all zeros is not linearly independent from itself. | ||
| columns.SetCol(len(idxs), newCol) | ||
| // This needs to change if zero columns are allowed, as |
There was a problem hiding this comment.
this comment is a bit confusing (to me at least).
it reads as if this piece of code needs to be changed, ie: as a TODO/FIXME.
perhaps:
// If zero columns are allowed and as a column of all zeros is
// not linearly independent with itself,
// mark this column as needing to be changed.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.