SVS-1245-add-custom-fields-to-gooddata-pipelines #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmatzek
force-pushed
the
SVS-1245-add-custom-fields-to-gooddata-pipelines
branch
from
3dcbaa4 to
e4ec7a3
Compare
janmatzek
requested review from
lupko,
pcerny,
jaceksan and
hkad98
as code owners
hkad98
reviewed
Sep 15, 2025
Comment on lines
215
to
224
| def get_workspace_layout(self, workspace_id: str) -> requests.Response: | ||
| """Get the layout of the specified workspace. | ||
| Args: | ||
| workspace_id (str): The ID of the workspace to retrieve the layout for. | ||
| Returns: | ||
| requests.Response: The response containing the workspace layout. | ||
| """ | ||
| endpoint = f"/layout/workspaces/{workspace_id}" | ||
| return self._get(endpoint) |
There was a problem hiding this comment.
Why not use get_declarative_workspace from gooddata_sdk?
hkad98
reviewed
Sep 15, 2025
Comment on lines
226
to
239
| def put_workspace_layout( | ||
| self, workspace_id: str, layout: dict[str, Any] | ||
| ) -> requests.Response: | ||
| """Update the layout of the specified workspace. | ||
| Args: | ||
| workspace_id (str): The ID of the workspace to update. | ||
| layout (dict[str, Any]): The new layout to set for the workspace. | ||
| Returns: | ||
| requests.Response: The response from the server after updating the layout. | ||
| """ | ||
| endpoint = f"/layout/workspaces/{workspace_id}" | ||
| headers = {**self.headers, "Content-Type": "application/json"} | ||
| return self._put(endpoint, data=layout, headers=headers) |
There was a problem hiding this comment.
Why not use put_declarative_workspace from gooddata_sdk?
hkad98
reviewed
Sep 15, 2025
Comment on lines
163
to
166
| @staticmethod | ||
| def _set_contains(set_to_check: set[Any], item: Any) -> bool: | ||
| """Helper function to check if an item is in a set.""" | ||
| return item in set_to_check |
There was a problem hiding this comment.
Is this method necessary? Why not simplify do the item in set_to_check?
hkad98
reviewed
Sep 15, 2025
Comment on lines
148
to
151
| if set_new_invalid_relations.issubset(set_current_invalid_relations): | ||
| return True | ||
| else: | ||
| return False |
There was a problem hiding this comment.
Suggested change
| if set_new_invalid_relations.issubset(set_current_invalid_relations): | |
| return True | |
| else: | |
| return False | |
| return set_new_invalid_relations.issubset(set_current_invalid_relations) |
hkad98
reviewed
Sep 15, 2025
Comment on lines
98
to
108
| metrics_response = self._api.get_all_metrics(workspace_id) | ||
| visualizations_response = self._api.get_all_visualization_objects( | ||
| workspace_id | ||
| ) | ||
| dashboards_response = self._api.get_all_dashboards(workspace_id) | ||
| self._api.raise_if_response_not_ok( | ||
| metrics_response, | ||
| visualizations_response, | ||
| dashboards_response, | ||
| ) |
There was a problem hiding this comment.
Would it be possible to use any methods from gooddata_sdk? This seems to me like re-implementing something that already exists.
There was a problem hiding this comment.
I don't think so. I need to use the "X-GDC-VALIDATE-RELATIONS": "true" header for these to get the areRelationsValid attribute. I didn't see a way to get that using the SDK.
There was a problem hiding this comment.
I see... maybe we could extend the gooddata_sdk to set custom headers somehow. Let's leave it for follow-up.
janmatzek
force-pushed
the
SVS-1245-add-custom-fields-to-gooddata-pipelines
branch
from
e4ec7a3 to
67d1d9b
Compare
hkad98
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.