Add working-directory input

[Nedu]

TL;DR

Deploy fails while asking for an app.yaml file even though it is present already.

Expected behavior

Expected it to be able to detect app.yaml and deployment to be successful.

Observed behavior

It throws the following error

ERROR: An app.yaml (or appengine-web.xml) file is required to deploy this directory as an App Engine application. Create an app.yaml file using the directions at https://cloud.google.com/appengine/docs/flexible/python/configuring-your-app-with-app-yaml (App Engine Flexible Environment) or https://cloud.google.com/appengine/docs/standard/python/config/appref (App Engine Standard Environment) under the tab for your language.
ERROR: (gcloud.app.deploy) [/home/runner/work] could not be identified as a valid source directory or file.

Reproduction

Action YAML

name: Deploy Server to Google App Engine

on: 
  push:
    branches: 
      - master
    paths:
      - 'server/**'
      - '.github/workflows/deploy.yml'

defaults:
  run:
    working-directory: server

jobs:
  build:
    name: Build
    runs-on: ubuntu-latest
    strategy:
      matrix:
        node-version: [14.9]

    steps:
    - name: Checkout Repo
      uses: actions/checkout@v2
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v2-beta
      with:
        node-version: ${{ matrix.node-version }}
    - name: Install Dependencies
      run: npm ci
    - name: Build Typescript
      run: npm run build:prod --if-present
    - name: Set up PostgreSQL
      uses: harmon758/postgresql-action@v1
      with:
        postgresql version: '12'
        postgresql db: ${{ secrets.DB_TEST }}
        postgresql user: ${{ secrets.DB_USER }}
        postgresql password: ${{ secrets.DB_PASSWORD }}
    - name: Run Tests
      run: npm run test:prod
      env:
        CI: true
        PORT: ${{ secrets.PORT }}
        DB_NAME: ${{ secrets.DB_NAME }}
        DB_TEST: ${{ secrets.DB_TEST }}
        DB_USER: ${{ secrets.DB_USER }}
        DB_PASSWORD: ${{ secrets.DB_PASSWORD }}
        DB_HOST: ${{ secrets.DB_HOST }}
        DB_DIALECT: ${{ secrets.DB_DIALECT }}
  deploy:
    needs: [build]
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - name: GCP Setup
      uses: google-github-actions/setup-gcloud@master
      with:
        version: '290.0.1'
        project_id: ${{ secrets.PROJECT_ID }}
        service_account_key: ${{ secrets.GCP_CREDENTIALS }}
        export_default_credentials: true
    - id: Deploy
      uses: google-github-actions/deploy-appengine@main
      with:
        credentials: ${{ secrets.GCP_CREDENTIALS }}

Additional information
app.yaml is included in the root of the server

[averikitsch]

Hi @Nedu, are you still experiencing this? Please try directly setting the path of the app.yaml using the deliverables input.

[averikitsch]

Closing due to no response.

[Nedu]

hi I still had problems when directly setting the path using the deliverables input. I was able to get it working by putting everything into one job

name: Deploy Server to Google App Engine

on: 
  push:
    branches: 
      - develop

jobs:
  build:
    name: Build
    runs-on: ubuntu-latest
    defaults:
      run:
        working-directory: ./server
    strategy:
      matrix:
        node-version: [14.9]

    steps:
    - name: Checkout Repo
      uses: actions/checkout@v2
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v2-beta
      with:
        node-version: ${{ matrix.node-version }}
    - name: Set up PostgreSQL
      uses: harmon758/postgresql-action@v1
      with:
        postgresql version: '12'
        postgresql db: ${{ secrets.DB_TEST }}
        postgresql user: ${{ secrets.DB_USER }}
        postgresql password: ${{ secrets.DB_PASSWORD }}
    - name: Install Dependencies
      run: npm ci
    - name: Build Typescript
      run: npm run build:prod --if-present
    - name: Run Tests
      run: npm run test:prod
      env:
        CI: true
        PORT: ${{ secrets.PORT }}
        DB_NAME: ${{ secrets.DB_NAME }}
        DB_TEST: ${{ secrets.DB_TEST }}
        DB_USER: ${{ secrets.DB_USER }}
        DB_PASSWORD: ${{ secrets.DB_PASSWORD }}
        DB_HOST: ${{ secrets.DB_HOST }}
        DB_DIALECT: ${{ secrets.DB_DIALECT }}
        SECRET: ${{ secrets.SECRET }}
        REFRESH_SECRET: ${{ secrets.REFRESH_SECRET }}
    - name: GCP Setup
      uses: google-github-actions/setup-gcloud@master
      with:
        version: '290.0.1'
        project_id: ${{ secrets.PROJECT_ID }}
        service_account_key: ${{ secrets.GCP_CREDENTIALS }}
        export_default_credentials: true
    - name: Setup Deployment Environment
      uses: vafinvr/template-env-action@master
      env:
        cloud_sql_instances: ${{ secrets.CLOUD_SQL_INSTANCES }}
        DB_NAME: ${{ secrets.DB_PROD_NAME }}
        DB_USER: ${{ secrets.DB_PROD_USER }}
        DB_PASSWORD: ${{ secrets.DB_PROD_PASSWORD }}
        DB_HOST: ${{ secrets.DB_PROD_HOST}}
        DB_DIALECT: ${{ secrets.DB_DIALECT }}
        INSTANCE_CONNECTION_NAME: ${{ secrets.INSTANCE_CONNECTION_NAME }}
        CLOUD_SQL_CONNECTION_NAME: ${{ secrets.CLOUD_SQL_CONNECTION_NAME }}
        SECRET: ${{ secrets.SECRET }}
        REFRESH_SECRET: ${{ secrets.REFRESH_SECRET }}
      with:
        filename: server/app.yml
    - id: Deploy
      uses: google-github-actions/deploy-appengine@main
      with:
        project_id: ${{ secrets.PROJECT_ID }}
        credentials: ${{ secrets.GCP_CREDENTIALS }}
        deliverables: server/app.yml

[averikitsch]

Workspaces and created artifacts are not shared between jobs. Where you creating the app.yaml in the first job? I do see that you are setting a working-directory, so I'll see if I can reproduce the problem.

[averikitsch]

working-directory setting does not apply to the actions as a general GitHub Actions limitation. @Nedu would an action input of working-directory (duplicating the default) be helpful or specifying the full path suffice?

[Nedu]

@averikitsch yes an action input of working-directory (duplicating the default) would be helpful

[ThomasPires]

I have the same issue. +1 to make working-directory works fine :) Thanks to you both