Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to export secrets as environment variables. #289

Merged
merged 2 commits into from
May 21, 2024

Conversation

codiophile
Copy link
Contributor

This adds an option to export the secrets as environment variables.

We need this, because we are migrating from using our own custom action for fetching secrets and our old action would directly export the secrets as environment variables, so to be able to maintain API compatibility, we need this action to be able to do the same. Otherwise we would have to make significant changes to our workflows to enable the migration.

For others, this will be convenient, as most secrets you fetch will end up in an environment variable anyway. This removes the need for the manual step of putting the output from this action as an environment variable in the step where it is used.

As per my implementation, the feature is disabled by default and needs to be enabled to be used, which means that it is fully backwards compatible and will not affect users that don't want to use this feature.

I've tested it in one of our pipelines and it is working fine. I've also run linting and tests locally, without any errors or failures.

@codiophile codiophile requested a review from a team as a code owner May 20, 2024 10:06
Copy link

google-cla bot commented May 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @codiophile are you able to sign the Google CLA please? Also, we need to update the documentation with this new input. I would also prefer if the documentation clarified that the environment variable key is exactly the same as the output key.

This change seems mostly fine, but I am worried about feature sprawl. For example, I can see someone wanting to "uppercase" the secret names before exporting them, but I think we can handle those when they arise.

src/main.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@codiophile
Copy link
Contributor Author

@sethvargo

Thank you for your review. I signed the CLA and addressed the review comments, except the one about logDebug, as I'm not sure what you are after.

@sethvargo sethvargo enabled auto-merge (squash) May 21, 2024 21:04
@sethvargo sethvargo merged commit 7bc4830 into google-github-actions:main May 21, 2024
5 checks passed
sethvargo pushed a commit that referenced this pull request May 21, 2024
## What's Changed
* Add option to export secrets as environment variables. by @codiophile
in
#289

## New Contributors
* @codiophile made their first contribution in
#289

**Full Changelog**:
v2.1.1...7bc4830
renovate bot referenced this pull request in valora-inc/dapp-list May 24, 2024
…ction to v2.1.2 (#626)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[google-github-actions/get-secretmanager-secrets](https://togithub.com/google-github-actions/get-secretmanager-secrets)
| action | patch | `v2.1.1` -> `v2.1.2` |

---

### Release Notes

<details>
<summary>google-github-actions/get-secretmanager-secrets
(google-github-actions/get-secretmanager-secrets)</summary>

###
[`v2.1.2`](https://togithub.com/google-github-actions/get-secretmanager-secrets/releases/tag/v2.1.2)

[Compare
Source](https://togithub.com/google-github-actions/get-secretmanager-secrets/compare/v2.1.1...v2.1.2)

##### What's Changed

- Add option to export secrets as environment variables. by
[@&#8203;codiophile](https://togithub.com/codiophile) in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/289](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/289)
- Release: v2.1.2 by
[@&#8203;google-github-actions-bot](https://togithub.com/google-github-actions-bot)
in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/291](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/291)

##### New Contributors

- [@&#8203;codiophile](https://togithub.com/codiophile) made their first
contribution in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/289](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/289)

**Full Changelog**:
google-github-actions/get-secretmanager-secrets@v2.1.1...v2.1.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - "after 8:00 before 23:00 every weekday except on Friday" in
timezone UTC.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/dapp-list).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImdpdGh1Yi1hY3Rpb25zIiwicmVub3ZhdGUiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot referenced this pull request in valora-inc/wallet Jun 1, 2024
…ction to v2 (#5509)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
|
[google-github-actions/get-secretmanager-secrets](https://togithub.com/google-github-actions/get-secretmanager-secrets)
| action | major | `v1.0.1` -> `v2.1.2` | `v2.1.3` |

---

### Release Notes

<details>
<summary>google-github-actions/get-secretmanager-secrets
(google-github-actions/get-secretmanager-secrets)</summary>

###
[`v2.1.2`](https://togithub.com/google-github-actions/get-secretmanager-secrets/releases/tag/v2.1.2)

[Compare
Source](https://togithub.com/google-github-actions/get-secretmanager-secrets/compare/v2.1.1...v2.1.2)

##### What's Changed

- Add option to export secrets as environment variables. by
[@&#8203;codiophile](https://togithub.com/codiophile) in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/289](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/289)
- Release: v2.1.2 by
[@&#8203;google-github-actions-bot](https://togithub.com/google-github-actions-bot)
in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/291](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/291)

##### New Contributors

- [@&#8203;codiophile](https://togithub.com/codiophile) made their first
contribution in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/289](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/289)

**Full Changelog**:
google-github-actions/get-secretmanager-secrets@v2.1.1...v2.1.2

###
[`v2.1.1`](https://togithub.com/google-github-actions/get-secretmanager-secrets/releases/tag/v2.1.1)

[Compare
Source](https://togithub.com/google-github-actions/get-secretmanager-secrets/compare/v2.1.0...v2.1.1)

##### What's Changed

- security: bump undici from 5.28.2 to 5.28.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/282](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/282)
- security: bump undici from 5.28.3 to 5.28.4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/284](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/284)
- Retry GETs on error by [@&#8203;glasser](https://togithub.com/glasser)
in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/285](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/285)
- Update deps by [@&#8203;sethvargo](https://togithub.com/sethvargo) in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/286](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/286)
- Release: v2.1.1 by
[@&#8203;google-github-actions-bot](https://togithub.com/google-github-actions-bot)
in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/287](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/287)

##### New Contributors

- [@&#8203;glasser](https://togithub.com/glasser) made their first
contribution in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/285](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/285)

**Full Changelog**:
google-github-actions/get-secretmanager-secrets@v2.1.0...v2.1.1

###
[`v2.1.0`](https://togithub.com/google-github-actions/get-secretmanager-secrets/releases/tag/v2.1.0)

[Compare
Source](https://togithub.com/google-github-actions/get-secretmanager-secrets/compare/v2.0.0...v2.1.0)

##### What's Changed

- Update README and CI to use latest version by
[@&#8203;sethvargo](https://togithub.com/sethvargo) in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/279](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/279)
- Update deps by [@&#8203;sethvargo](https://togithub.com/sethvargo) in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/280](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/280)
- Release: v2.1.0 by
[@&#8203;google-github-actions-bot](https://togithub.com/google-github-actions-bot)
in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/281](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/281)

**Full Changelog**:
google-github-actions/get-secretmanager-secrets@v2...v2.1.0

###
[`v2.0.0`](https://togithub.com/google-github-actions/get-secretmanager-secrets/releases/tag/v2.0.0)

[Compare
Source](https://togithub.com/google-github-actions/get-secretmanager-secrets/compare/v1.0.1...v2.0.0)

**:warning: This version requires Node 20 or later!**

##### What's Changed

- dependabot: only do security updates by
[@&#8203;sethvargo](https://togithub.com/sethvargo) in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/266](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/266)
- update all deps by [@&#8203;sethvargo](https://togithub.com/sethvargo)
in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/267](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/267)
- Update deps to Node 20 by
[@&#8203;sethvargo](https://togithub.com/sethvargo) in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/273](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/273)
- Drop mocha and chai by
[@&#8203;sethvargo](https://togithub.com/sethvargo) in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/274](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/274)
- Add CI for release branches by
[@&#8203;sethvargo](https://togithub.com/sethvargo) in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/275](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/275)
- Update deps by [@&#8203;sethvargo](https://togithub.com/sethvargo) in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/276](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/276)
- Release: v2.0.0 by
[@&#8203;google-github-actions-bot](https://togithub.com/google-github-actions-bot)
in
[https://github.com/google-github-actions/get-secretmanager-secrets/pull/278](https://togithub.com/google-github-actions/get-secretmanager-secrets/pull/278)

**Full Changelog**:
google-github-actions/get-secretmanager-secrets@v1...v2.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJnaXRodWItYWN0aW9ucyIsInJlbm92YXRlIl19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants