Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setSelectionOverride(index, tracks, null) doesn't behave as advertised #2988

Closed
ojw28 opened this issue Jun 23, 2017 · 1 comment
Closed

setSelectionOverride(index, tracks, null) doesn't behave as advertised #2988

ojw28 opened this issue Jun 23, 2017 · 1 comment
Assignees
@ojw28
Labels
bug

Comments

@ojw28
Copy link
Contributor

ojw28 commented Jun 23, 2017

As per title. This currently has the same same effect as clearing an override, but should disable the renderer for the specified tracks. Reported in #2982.
@ojw28 ojw28 self-assigned this Jun 23, 2017
@ojw28 ojw28 added the bug label Jun 23, 2017
@ojw28 ojw28 mentioned this issue Jun 23, 2017
Closed
ojw28 added a commit that referenced this issue Jun 24, 2017
@ojw28
Fix setSelectionOverride(index, tracks, null)
c007e93 
Issue: #2988

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=159958591
@ojw28
Copy link
Contributor Author

ojw28 commented Jun 24, 2017

Fixed and added a test. Thanks.

@ojw28 ojw28 closed this as completed Jun 24, 2017
ojw28 added a commit that referenced this issue Jun 30, 2017
@ojw28
Fix setSelectionOverride(index, tracks, null)
fd9b162 
Issue: #2988

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=159958591
@google google locked and limited conversation to collaborators Oct 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ojw28 ojw28

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ojw28