-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Providing a Minimal Example #383
Comments
We'll probably be doing this by moving the "player" package from the demo app to inside the library, as a higher level abstraction that covers playback for most of the common use cases. You'll still be able to use the lower level ExoPlayer interface directly for more advanced use cases. Does that sound good/sensible to you? |
What kind of abstraction will this provide? I am not sure if this is necessary, if there is a good documentation and examples (like ffmpeg provides) it should be easy for everyone. When using maven repo the demo is not included, does it have a reason? |
The new plan will likely be:
Details to be determined. |
The first bullet point above has been completed, and ~10% of the demo app code has been removed as a result. The second and third points are still open for investigation. |
DemoPlayer moves into core library as SimpleExoPlayer, which implements ExoPlayer. Issue: #383 Issue: #592 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=123090184
The demo app has been significantly reduced in size in ExoPlayer V2. For V1 we had:
in V2 we have:
If you ignore the files that are essentially just scaffolding (i.e. not interesting), the lines of code goes from 2246 to 910. |
Having the huge Examples is quite good to get a good feeling of exoplayer's wide range of possibilities. However, it would be very helpful to have a minimal working example, which shows what is needed to play a video from file or link.
The above code yields:
04-06 01:47:18.920 Unsupported mime video/mpeg2
04-06 01:47:18.921 Unsupported mime audio/mpeg-L2
04-06 01:47:18.923 Unrecognized level 0 for video/x-vnd.on2.vp8
The text was updated successfully, but these errors were encountered: