Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspicious null in method overload #4403

Closed
Manuiq opened this issue Jun 21, 2018 · 2 comments
Closed

Suspicious null in method overload #4403

Manuiq opened this issue Jun 21, 2018 · 2 comments
Assignees
@andrewlewis
Labels
bug

Comments

@Manuiq
Copy link

Manuiq commented Jun 21, 2018 •
edited

In overloaded cache method instead of passing @Nullable AtomicBoolean isCanceled argument this method just passes null next. So now modifying the AtomicBoolean doesn't cancel the caching.

ExoPlayer/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CacheUtil.java

Line 135 in 000f3f2

null,

@tonihei
Copy link
Collaborator

tonihei commented Jun 21, 2018

That looks indeed suspicious. @erdemguven Can you take a look?

@tonihei tonihei added the bug label Jun 21, 2018
@andrewlewis
Copy link
Collaborator

My bad in a0b1559. I'll make a fix to use the passed in flag. Thanks for reporting this.

ojw28 pushed a commit that referenced this issue Jun 22, 2018
@andrewlewis @ojw28
Fix download cancellation
a610857 
Issue: #4403

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=201525284
ojw28 pushed a commit that referenced this issue Jun 25, 2018
@andrewlewis @ojw28
Fix download cancellation
680d3fd 
Issue: #4403

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=201525284
@ojw28 ojw28 closed this as completed Jun 25, 2018
@google google locked and limited conversation to collaborators Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrewlewis andrewlewis

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@andrewlewis @Manuiq @ojw28 @erdemguven @tonihei