fix: improve json serialization by allowing non-ascii characters #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Previously accepted JSON objects directly, which was less robust. Now serialize arguments to JSON strings using `_safe_json_serialize`, ensuring stability and handling non-ASCII characters correctly.
|
I don't know if ensure_ascii is the problem. Ideally even if Chinese character is encoded in dumps(), once you loads() it should restore back to the correct characters. |
The input to the LLM is a JSON string. I think setting ensure_ascii=False would help the LLM handle non-ASCII responses better. |
selcukgun
approved these changes
May 28, 2025
|
Assuming this is useful for logging purposes (regarding json.loads not needing this). |
selcukgun
added
the
ready to pull
copybara-service bot
pushed a commit
that referenced
this pull request
May 28, 2025
-- 50b09bb by Yuan Chai <350365422@qq.com>: fix: improve json serialization by allowing non-ascii characters -- c66977a by Yuan Chai <350365422@qq.com>: fix: serialize function call arguments to JSON string Previously accepted JSON objects directly, which was less robust. Now serialize arguments to JSON strings using `_safe_json_serialize`, ensuring stability and handling non-ASCII characters correctly. COPYBARA_INTEGRATE_REVIEW=#605 from nauyiahc:fix_non_ascii_char a52513c PiperOrigin-RevId: 764396496
|
merged by copybara: c4cd180 |
raflFaisal
pushed a commit
to raflFaisal/adk-python
that referenced
this pull request
May 28, 2025
-- 50b09bb by Yuan Chai <350365422@qq.com>: fix: improve json serialization by allowing non-ascii characters -- c66977a by Yuan Chai <350365422@qq.com>: fix: serialize function call arguments to JSON string Previously accepted JSON objects directly, which was less robust. Now serialize arguments to JSON strings using `_safe_json_serialize`, ensuring stability and handling non-ASCII characters correctly. COPYBARA_INTEGRATE_REVIEW=google#605 from nauyiahc:fix_non_ascii_char a52513c PiperOrigin-RevId: 764396496
whhlct
pushed a commit
to whhlct/adk-python
that referenced
this pull request
Jun 6, 2025
-- 50b09bb by Yuan Chai <350365422@qq.com>: fix: improve json serialization by allowing non-ascii characters -- c66977a by Yuan Chai <350365422@qq.com>: fix: serialize function call arguments to JSON string Previously accepted JSON objects directly, which was less robust. Now serialize arguments to JSON strings using `_safe_json_serialize`, ensuring stability and handling non-ASCII characters correctly. COPYBARA_INTEGRATE_REVIEW=google#605 from nauyiahc:fix_non_ascii_char a52513c PiperOrigin-RevId: 764396496
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
-- 50b09bb by Yuan Chai <350365422@qq.com>: fix: improve json serialization by allowing non-ascii characters -- c66977a by Yuan Chai <350365422@qq.com>: fix: serialize function call arguments to JSON string Previously accepted JSON objects directly, which was less robust. Now serialize arguments to JSON strings using `_safe_json_serialize`, ensuring stability and handling non-ASCII characters correctly. COPYBARA_INTEGRATE_REVIEW=google#605 from nauyiahc:fix_non_ascii_char a52513c PiperOrigin-RevId: 764396496
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated _safe_json_serialize to use json.dumps(obj, ensure_ascii=False). This allows non-ASCII characters to be preserved in JSON output, improving readability and compatibility for internationalization.
Addresses Non-ASCII characters (for example, Chinese characters) in tool responses are escaped before being sent to the LLM. #472
The
Functionclass'sargumentsfield accepts a JSON string instead of a raw JSON object. This change ensures stability and handles non-ASCII characters correctly, making the arguments more robust and easier to serialize.