Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from 0.5.7 to 0.5.8 #146

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Update from 0.5.7 to 0.5.8 #146

merged 2 commits into from
Mar 2, 2017

Conversation

jcoatgoogle
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.501% when pulling bb1f46d on jcoatgoogle:jco_update_version into 1f57d98 on google:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.501% when pulling 1baacc6 on jcoatgoogle:jco_update_version into 1f57d98 on google:master.

vilasj
vilasj reviewed Mar 2, 2017
View reviewed changes
apitools/base/py/batch_test.py
@@ -153,6 +153,7 @@ def testSingleRequestInBatch(self):
desired_url = 'https://www.example.com'

callback_was_called = []

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for readability?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow, when I committed it it didn't make pep8 unhappy, but now it did.

@vilasj vilasj merged commit ad43dd1 into google:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilasj vilasj vilasj approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcoatgoogle @coveralls @vilasj @googlebot