Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean service names in the registry so as not to write syntax errors #240

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Clean service names in the registry so as not to write syntax errors #240

merged 1 commit into from
Aug 7, 2018

Conversation

sixolet
Copy link
Contributor

@sixolet sixolet commented Aug 7, 2018

Generating a client with a dash in the service name produced invalid code.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 91.686% when pulling 410b417 on sixolet:master into a24daf7 on google:master.

@vilasj vilasj requested a review from kevinli7 August 7, 2018 17:32
@kevinli7
Copy link
Contributor

kevinli7 commented Aug 7, 2018

Travis CI is failing due to unrelated changes.

@kevinli7 kevinli7 merged commit 72130a5 into google:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinli7 kevinli7 kevinli7 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sixolet @coveralls @kevinli7 @googlebot