Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using google/jarjar instead of pantsbuild/jarjar #21

Open
cushon opened this issue May 24, 2018 · 2 comments
Open

Consider using google/jarjar instead of pantsbuild/jarjar #21

cushon opened this issue May 24, 2018 · 2 comments
Labels

Comments

@cushon
Copy link
Contributor

cushon commented May 24, 2018

Bazel itself uses https://github.com/google/jarjar. It's actually distributed with Bazel as @bazel_tools//third_party/java/jarjar:jarjar_import, although you may not want to depend on those labels for bazel-common.

@ronshapiro
Copy link
Contributor

ronshapiro commented May 25, 2018 via email

@cushon
Copy link
Contributor Author

cushon commented May 25, 2018

It's distributed with Bazel as @bazel_tools//third_party/java/jarjar:jarjar_import

Er, that's actually the pre-google/jarjar version. The next Bazel release will be using google/jarjar, but at a different label in @bazel_tools//third_party/jarjar instead.

Depending on the repo directly might be more robust than using @bazel_tools.

@cpovirk cpovirk added the P3 label Jul 25, 2019
or-shachar referenced this issue Mar 28, 2020
Verified in (and soon to be included in) Flogger

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=193557188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants