Event loop implementation for Android. #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hysw
force-pushed
the
tianc/android-event-loop
branch
2 times, most recently
from
b537af7
to
f2eeba8
Compare
hysw
force-pushed
the
tianc/android-event-loop
branch
2 times, most recently
from
cdf668b
to
4976d67
Compare
chaoticbob
reviewed
Apr 25, 2023
hysw
force-pushed
the
tianc/android-event-loop
branch
2 times, most recently
from
e6f2691
to
f339316
Compare
Keenuts
approved these changes
Apr 27, 2023
| mAndroidApp->userData = this; | ||
| } | ||
|
|
||
| Result WindowImplAndroid::Create(const char* title) |
There was a problem hiding this comment.
That's a C style string, pTitle sounds like const char**
- Add event process to the application main loop. - Read screen resolution from Android window. - Pass touch input to ImGui.
hysw
force-pushed
the
tianc/android-event-loop
branch
from
f339316
to
1be5ddb
Compare
|
This PR seems to have messed with the rendered image on the two XR projects. |
|
closes #126 |
This was referenced May 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a bit annoyed at
#if definedstatements, and trying to figure out what is the exact control flow, so I pulled out the part that are glfw or android specificThe new stuff