Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abstraction for platform window operations. #136

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Add abstraction for platform window operations. #136

merged 2 commits into from
Apr 26, 2023

Conversation

hysw
Copy link
Collaborator

@hysw hysw commented Apr 25, 2023

  • So we can remove 20 of #if defined
  • Remove platform specific clutter from Application

@hysw
Copy link
Collaborator Author

hysw commented Apr 25, 2023 •
edited
Loading

  • d17a434 is just copying part of application.cpp so later diff actually make sense
  • dfd2ccd contains the actual diffs

@hysw hysw force-pushed the tianc/platform-window branch 2 times, most recently from 9d30d2d to dfd2ccd Compare April 25, 2023 20:44
@hysw hysw mentioned this pull request Apr 25, 2023
Merged
wangra-google
wangra-google reviewed Apr 25, 2023
View reviewed changes
include/ppx/window.h Outdated Show resolved Hide resolved
chaoticbob
chaoticbob suggested changes Apr 26, 2023
View reviewed changes
include/ppx/window.h Show resolved Hide resolved
chaoticbob
chaoticbob suggested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@chaoticbob chaoticbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some allocation error checking.

src/ppx/application.cpp Show resolved Hide resolved
src/ppx/application.cpp Show resolved Hide resolved
chaoticbob
chaoticbob approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@chaoticbob chaoticbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hysw hysw merged commit 7d423ab into google:main Apr 26, 2023
This was referenced May 1, 2023
Closed
Closed
@hysw hysw deleted the tianc/platform-window branch May 4, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoticbob chaoticbob chaoticbob approved these changes

@wangra-google wangra-google wangra-google approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hysw @chaoticbob @wangra-google