Skip to content

Conversation

mRoca
Copy link

@mRoca mRoca commented Nov 27, 2017

Hello,

This PR is a replacement proposal for #1597 without adding a new storage driver, without the new options added by @oopschen for now (I can add them if we choose to implement this way).

The main problem, here, is the usage of 2 libraries for the same storage engine: the most recent one (elastic.v5) and the legacy one (elastic.v2) for the backward compatibility.

This PR (or the other one) fixes #1753 and #1517 .

WDYT about it ?

@k8s-ci-robot
Copy link
Collaborator

Hi @mRoca. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiangpengzhao
Copy link

/ok-to-test

note: this command is a test of kubernetes/test-infra#5793

@mRoca mRoca force-pushed the feature/elastic-5 branch from bf3d0e9 to 11fdf09 Compare December 5, 2017 10:05
@dashpole dashpole self-assigned this Jun 21, 2019
@bobbypage
Copy link
Contributor

This PR is very out of date and abandoned as well as we don't want to add new storage drivers, see #1458 (comment)

As a result, closing this PR for now.

@bobbypage bobbypage closed this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cadvisor import stats not working with stdout and elasticsearch
5 participants