Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golang module for canonical protos. Move existing go module under tests #342

Merged
merged 9 commits into from
Mar 26, 2024
Merged

Add golang module for canonical protos. Move existing go module under tests #342

merged 9 commits into from
Mar 26, 2024

Conversation

l46kok
Copy link
Collaborator

@l46kok l46kok commented Mar 19, 2024 •
edited
Loading

This change is to allow serving canonical protos cel.dev/expr for golang via go get cel.dev/expr.

sergiitk
sergiitk approved these changes Mar 20, 2024
View reviewed changes
@l46kok l46kok marked this pull request as ready for review March 20, 2024 20:28
@l46kok l46kok requested a review from TristonianJones March 20, 2024 20:28
sergiitk
sergiitk reviewed Mar 20, 2024
View reviewed changes
@l46kok l46kok force-pushed the move-test-protos-to-submodule branch from e6233d1 to 9413025 Compare March 21, 2024 19:14
TristonianJones
TristonianJones previously approved these changes Mar 22, 2024
View reviewed changes
@sergiitk
Copy link
Member

sergiitk commented Mar 22, 2024 •
edited
Loading

@l46kok you might want to setup .gitattributes to mark pb.go files binary.

@sergiitk
Copy link
Member

See https://github.com/cncf/xds/blob/6b7cb9e61ad79c99765a1dea2bede517d1b7db3e/.gitattributes#L1-L2

*.pb.go linguist-generated=true
*.pb.go -diff -merge

@l46kok l46kok force-pushed the move-test-protos-to-submodule branch 2 times, most recently from fc225e8 to 2f78ea9 Compare March 22, 2024 20:20
@l46kok l46kok force-pushed the move-test-protos-to-submodule branch from 2f78ea9 to d8bbb06 Compare March 22, 2024 20:21
@l46kok
Copy link
Collaborator Author

l46kok commented Mar 22, 2024

PTAL

@l46kok l46kok merged commit ae15d29 into google:master Mar 26, 2024
2 checks passed
@l46kok l46kok deleted the move-test-protos-to-submodule branch March 26, 2024 21:31
This was referenced Mar 27, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiitk sergiitk sergiitk approved these changes

@TristonianJones TristonianJones TristonianJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l46kok @sergiitk @TristonianJones