Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Project import generated by Copybara. #1

Closed
wants to merge 1 commit into from
Closed

Conversation

nshahan
Copy link
Contributor

@nshahan nshahan commented Mar 12, 2018

Initial export.

PiperOrigin-RevId: 188772624

PiperOrigin-RevId: 188772624
@nshahan nshahan requested a review from mit-mit March 12, 2018 21:41
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@mit-mit
Copy link
Member

mit-mit commented Mar 13, 2018

@nshahan the CLA bot doesn't seem so happy; is it expected that you are not the only listed committer in https://github.com/google/charts/pull/1/commits ?

@nshahan
Copy link
Contributor Author

nshahan commented Mar 13, 2018

Yes, this initial commit was squashed into one blob and the author was configured as "Googler". Future commits will be iterative and should have the original authors.

To avoid these warnings, we will need to ensure that internal authors register their github accounts with google we add their account to our internal pass through list. I have worked with the team to make sure that the members currently contributing are added.

@nshahan
Copy link
Contributor Author

nshahan commented Mar 13, 2018

Oh interesting, let me investigate. I haven't run into this as a commit blocker before on our dart-lang repos.

@nshahan
Copy link
Contributor Author

nshahan commented Mar 13, 2018

Closing in favor of #2.

@nshahan nshahan closed this Mar 13, 2018
@nshahan nshahan deleted the github-sync branch March 15, 2018 23:53
@Nik99 Nik99 mentioned this pull request Sep 10, 2018
equweiyu added a commit to equweiyu/charts that referenced this pull request Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants