Skip to content
This repository was archived by the owner on Sep 19, 2025. It is now read-only.

Conversation

alubbe
Copy link
Contributor

@alubbe alubbe commented Dec 12, 2016

This PR has come out of the suggestion to investigate nailgun google/closure-compiler#2186

fast-closure-compiler passes the arguments to a python script which in turn passes it to the nailgun server. -jar gets passed all the way down to the closure compiler, resulting in this error:

"-jar" is not a valid option

Therefore, I suggest to not add -jar if JAR_PATH is falsy. Library consumers like me then have a switch to extend this libraries' functionality to work with nailgun.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@alubbe
Copy link
Contributor Author

alubbe commented Dec 12, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@ChadKillingsworth
Copy link
Collaborator

Works for me.

@ChadKillingsworth ChadKillingsworth merged commit 8a77a9c into google:master Dec 12, 2016
@alubbe alubbe deleted the empty-jar-path branch December 13, 2016 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants