Added match_text_output tutorial validation method #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusBordihn
requested changes
Oct 4, 2018
src/ui/tutorial/validator.js
Outdated
| break; | ||
| case cwc.ui.TutorialValidator.Type.MATCH_TEXT_OUTPUT: | ||
| this.validateByMatchTextOutput_(validate['value'], | ||
| 'message' in validate && typeof validate['message'] == 'string' ? |
There was a problem hiding this comment.
Trailing spaces not allowed.
src/ui/tutorial/validator.js
Outdated
| case cwc.ui.TutorialValidator.Type.MATCH_TEXT_OUTPUT: | ||
| this.validateByMatchTextOutput_(validate['value'], | ||
| 'message' in validate && typeof validate['message'] == 'string' ? | ||
| validate['message'] : 'Great Job!'); |
There was a problem hiding this comment.
Unexpected tab character .
adamcarheden
force-pushed
the
text-match
branch
from
7adcdcf to
e6436d5
Compare
|
Mistakenly omitted the file name last last time I committed before pushing. Linter changes should now be fixed. |
MarkusBordihn
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets tutorials provide feedback by matching the text output of the user's program. This will be much simpler for tutorial authors than writing code and will facilitate the tutorial editor UI I'm also working on. The new hello.cwct card demonstrates the feature in step 4.