Added What's New! banner #210
Conversation
Marten and I decided to try just launching the changlog modal instead of the banner in the latest commit, so I didn't think a dedicated whats_new directory made sense anymore. There's less code and it's spread between the select screen and help. Let me know if you still think it makes sense to consolidate it into a directory somewhere. |
|
It should be still separated as module and not be hacked into the select screen for several reasons. Ideal it should be located under src/ui/whats_new_screen/ which will be showed once after the start as an overlay of the select screen, but not as part of it. |
Patch set 3 puts it in a separate directory. The select screen still needs to call it. Existing changelog code is part of src/ui/help, so I left that in place. That also calls a method to initialize the checkbox. |
|
FWIW I would like it in the select screen. For I suspect many people
(myself included) this screen is still the default. I don't want to ambush
people after they boot CWC because that is very interruptive if they are
already on their journey to the mode they want.
If I'm wrong and weird for leaving the select screen then nobody will see
it anyway.
Note: I am not super fierce about this but I really think it's bad design
to remove it from the first screen many users see (especially new users)
…-M
On Wed, 23 Jan 2019 at 17:59, Adam Carheden ***@***.***> wrote:
It should be still separated as module and not be hacked into the select
screen for several reasons.
The select screen is use to select the different modes, the whats new
feature is not really fitting into this concept and should be ideal
completely separated from the select screen.
Ideal it should be located under src/ui/whats_new_screen/ which will be
showed once after the start as an overlay of the select screen, but not as
part of it.
Patch set 3 puts it in a separate directory. The select screen still needs
to call it. Existing changelog code is part of src/ui/help, so I left that
in place. That also calls a method to initialize the checkbox.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#210 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AP6sVAq60TwO2ILqzxuVAUqsfrc9VGwjks5vGKMDgaJpZM4aLs_r>
.
|
|
@adamcarheden @MartenvanWezel This means even if this is in a separate folder it could be shown together with the select screen. Furthermore its planned to skip the select screen for the web version in the future, so that the user could directly open any project over an parameter. |
|
Markus,
I think PS 3 does the code separation adequately, but let me know if if it
doesn't. It still doesn't the check every time it displays a select screen
template, but I think only welcome, normal and advanced call that function,
all of which need to do the check.
…On Wed, Jan 23, 2019, 5:29 PM Markus Bordihn ***@***.*** wrote:
@adamcarheden <https://github.com/adamcarheden>
Thanks for the changes.
@MartenvanWezel <https://github.com/MartenvanWezel>
Sorry to be not clear about this, it should be separated from the code pov.
This means even if this is in a separate folder it could be shown together
with the select screen.
But the main difference is, we don't need to check every-time the user
open's the select screen for the "whats new" settings, possible changes,
... so this will be only checked once during the start of cwc.
Furthermore its planned to skip the select screen for the web version in
the future, so that the user could directly open any project over an
parameter.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#210 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABAqBCqJygFdoV0C5zyTXznBf-N41mPMks5vGP5ggaJpZM4aLs_r>
.
|
No description provided.