ja: : cr2 Day 3 translations

[henrif75]

Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content is reviewed.

#1463 #652

[HidenoriKobayashi]

Just comments. OWNERS have to agree.

[HidenoriKobayashi]

Just comments. OWNERS have to agree.

[henrif75]

Just comments. OWNERS have to agree.

Hi @HidenoriKobayashi thanks so much for your help!
One tip is that you can use suggest code changes that can be directly applied to the code. Check out this help article, thanks!

[HidenoriKobayashi]

Hi @HidenoriKobayashi thanks so much for your help! One tip is that you can use suggest code changes that can be directly applied to the code. Check out this help article, thanks!

Thanks for the tip @henrif75 ! I didn't know that you can make a suggestion that spans multiple lines using the codespace. I'll do that next time to make everyone's life easy :)

[HidenoriKobayashi]

I briefly went though the slides for Day 2 again.

Besides some suggestions (some are due to my bad comments, sorry), I found some places the original English text is shown in the browser.

I think we can merge this in the next round. Thanks!

[henrif75]

I briefly went though the slides for Day 2 again.

Besides some suggestions (some are due to my bad comments, sorry), I found some places the original English text is shown in the browser.

I think we can merge this in the next round. Thanks!

Hi @HidenoriKobayashi I believe we took care of all comments. The problem where some parts are still in English might be solved when we refresh and msgmerge the .po file.
One more think, can you check this to solve the CLA issue?

Thanks!

[HidenoriKobayashi]

Hi @HidenoriKobayashi I believe we took care of all comments. The problem where some parts are still in English might be solved when we refresh and msgmerge the .po file. One more think, can you check this to solve the CLA issue?

Thanks!

Thanks for the fixes! I think this chapter is ready to merge.

Re: CLA issue, go/github shows my private account is linked, and I have my chromium email added to my private account. I had no problem contributing other google projects. Could you help figuring out what I'm missing? @henrif75

Besides, I don't seem to have the permission to approve. I thought Martin had added me to the project (#652 (comment)). Maybe I needed to do something on my side to actually join this project?

[henrif75]

Hi @HidenoriKobayashi I believe we took care of all comments. The problem where some parts are still in English might be solved when we refresh and msgmerge the .po file. One more think, can you check this to solve the CLA issue?
Thanks!

Thanks for the fixes! I think this chapter is ready to merge.

Re: CLA issue, go/github shows my private account is linked, and I have my chromium email added to my private account. I had no problem contributing other google projects. Could you help figuring out what I'm missing? @henrif75

Besides, I don't seem to have the permission to approve. I thought Martin had added me to the project (#652 (comment)). Maybe I needed to do something on my side to actually join this project?

Hi @HidenoriKobayashi you should have gotten an invitation from GitHub to join the repository as a writer, when you accept it the issue with approvals should be fixed.

I'll try to figure out what's going on with the CLA and I'll circle back.

[HidenoriKobayashi]

LGTM. Thanks!