Fix content reader for partial input #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you. Please can we have a test to exercise this? |
When there is partial message in reader, popping out the characters lead to parse errors on the subsequent attempt to parse. To avoid this, the last matched characters' index is stored during parsing and reset on error.
Puneetha-Ramachandra
force-pushed
the
fix-content-reader
branch
from
6faf2c7 to
38bea5f
Compare
|
Added test. PTAL. |
|
Great, thank you again! |
mcnulty
added a commit
to mcnulty/cppdap
that referenced
this pull request
Jul 5, 2023
Per google#115, `ContentReader::match` must block until the whole pattern is read or the underlying `Reader` is closed. The previous commit reverted the change from google#50 to ensure this behavior is still implemented. This commit re-adds the unit test from google#50 with an update to the behavior of `StringBuffer` to correct implement `Reader` so that the partial read test case is still covered by the unit tests.
ben-clayton
pushed a commit
that referenced
this pull request
Jul 5, 2023
Per #115, `ContentReader::match` must block until the whole pattern is read or the underlying `Reader` is closed. The previous commit reverted the change from #50 to ensure this behavior is still implemented. This commit re-adds the unit test from #50 with an update to the behavior of `StringBuffer` to correct implement `Reader` so that the partial read test case is still covered by the unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is partial message in reader, popping out the
characters lead to parse errors on the subsequent attempt
to parse. To avoid this, the last matched characters'
index is stored during parsing and reset on error.