Skip to content

build_android: Only build replay and layer #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 24, 2025
Merged

build_android: Only build replay and layer #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1825883
build_android: Only build replay (and layer)
footballhead Aug 21, 2025
dfd99ee
Merge branch 'main' into build_android_gfxr_replay_only
footballhead Sep 18, 2025
98d1758
Merge branch 'main' of https://github.com/google/dive into build_andr…
footballhead Sep 24, 2025
1d00449
Update Windows script to match Linux
footballhead Sep 24, 2025
27f92b2
Build both layer and replay
footballhead Sep 24, 2025
b138e92
Copy changes to build_android.bat as well
footballhead Sep 24, 2025
313a0aa
Merge branch 'main' into build_android_gfxr_replay_only
footballhead Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ else()
set(DIVE_GFXR_GRADLE_CONSOLE "verbose" CACHE LIST "Value of --console to use when building GFXR with Gradle")
message(CHECK_START "Build gfxr for android")
execute_process(
COMMAND ./gradlew assemble${CMAKE_BUILD_TYPE} --console=${DIVE_GFXR_GRADLE_CONSOLE} -P${ANDROID_ABI}
COMMAND ./gradlew layer:assemble${CMAKE_BUILD_TYPE} replay:assemble${CMAKE_BUILD_TYPE} --console=${DIVE_GFXR_GRADLE_CONSOLE} -P${ANDROID_ABI}
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/third_party/gfxreconstruct/android
COMMAND_ERROR_IS_FATAL ANY
)
Expand Down
2 changes: 1 addition & 1 deletion scripts/build_android.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ pushd !GFXR_ROOT_DIR!
set build=%%b

echo GFXR_ROOT_DIR: !GFXR_ROOT_DIR!
call gradlew assemble!build! --console=verbose -Parm64-v8a
call gradlew layer:assemble!build! replay:assemble!build! --console=verbose -Parm64-v8a
))
popd

Expand Down