Repository navigation
Replies: 2 comments
|
The published EGM flow does look like it stops at implementation. The README says that after you approve the design you "ask your coding agent to implement it," and that a Goldfish review "does not replace tests or human judgment." Until then, the practical step between implement and merge is still yours: derive acceptance checks from the approved spec, keep them in CI, and run them on the implementation before merge. If those checks need to be out of the implementing agent's reach, they have to live somewhere the agent can't edit, for example a protected CI job or a test suite outside the agent's writable workspace. Tests sitting next to the code the agent is changing don't give you that isolation. If you also want the implementing agent itself to not call the work done until a check you choose passes, one option is omk, an MIT TypeScript coding-agent CLI. You set a goal and approve a verify command; omk reruns it after each settled turn and only completes the goal when that command exits 0 on the current workspace: Swap (Disclosure: I maintain omk.) |
|
I tried EGM on a small task, just a documentation change. After the implementation, I ran I didn't have tests written from the spec to check the result. The drift report was my only check after the code. It compared the design with what was built, but it didn't run anything. I wrote up that pass here: https://x.com/c_calabro/status/2120546834716254615 |
Uh oh!
There was an error while loading. Please reload this page.
The README is clear that a Goldfish review ‘does not replace tests or human judgment’, and the isolation work, including the canary probe and the #237 finding on instruction files, is unusually careful. The workflow ends at ‘ask your coding agent to implement it’, though. Is there a recommended step between implementation and merge that checks the code’s behaviour against the approved spec, for example acceptance tests derived from the spec and kept out of the implementing agent’s reach? /egm-drift-report compares structure to documents, but nothing in the flow runs the result. Is that deliberately out of scope, or a planned stage?
All reactions