This repository was archived by the owner on Jul 12, 2023. It is now read-only.
update docs around sending chaff requests #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
sethvargo
approved these changes
Dec 2, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
whaught
reviewed
Dec 2, 2020
|
|
||
| * MUST resent the `X-API-Key` header with a valid API key (oterwise you will | ||
| get an authorized error) | ||
| * MUST be sent via a `POST` requesxt, otherwise you will get an invalid method |
There was a problem hiding this comment.
Suggested change
| * MUST be sent via a `POST` requesxt, otherwise you will get an invalid method | |
| * MUST be sent via a `POST` request, otherwise you will get an invalid method |
|
|
||
| Chaff requests: | ||
|
|
||
| * MUST resent the `X-API-Key` header with a valid API key (oterwise you will |
There was a problem hiding this comment.
Suggested change
| * MUST resent the `X-API-Key` header with a valid API key (oterwise you will | |
| * MUST send the `X-API-Key` header with a valid API key (otherwise you will |
| Chaff requests: | ||
|
|
||
| * MUST resent the `X-API-Key` header with a valid API key (oterwise you will | ||
| get an authorized error) |
There was a problem hiding this comment.
Suggested change
| get an authorized error) | |
| get an unauthorized error) |
| get an authorized error) | ||
| * MUST be sent via a `POST` requesxt, otherwise you will get an invalid method | ||
| error | ||
| * SHOULD send a valid JSON body with padding out to the same size as the rest |
There was a problem hiding this comment.
Suggested change
| * SHOULD send a valid JSON body with padding out to the same size as the rest | |
| * SHOULD send a valid JSON body with random padding similar in size as the rest |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Release Note