Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

Updating realm admin guide #1264

Merged
merged 6 commits into from
Dec 4, 2020
Merged

Updating realm admin guide #1264

merged 6 commits into from
Dec 4, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Dec 4, 2020 •
edited
Loading

Issue #1250

Proposed Changes

  • Adding documentation on realm settings
    • Updated screenshots
    • New section about code settings

Release Note

Added user-guide documentation on realm-admin code settings.

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 4, 2020
@whaught whaught changed the title [WIP / DO NOT REVIEW] Updating realm admin guide Updating realm admin guide Dec 4, 2020
@whaught
Copy link
Contributor Author

whaught commented Dec 4, 2020

/hold
for everyone interested to take a look

sethvargo
sethvargo approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@whaught
Copy link
Contributor Author

whaught commented Dec 4, 2020

/hold cancel
The bulk code will be a new PR

@google-oss-robot google-oss-robot merged commit f5085fc into google:main Dec 4, 2020
@whaught whaught deleted the bulk-issue-guide branch December 4, 2020 05:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremyfaller jeremyfaller Awaiting requested review from jeremyfaller

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

1 more reviewer

@sethvargo sethvargo sethvargo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mikehelmick mikehelmick

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whaught @google-oss-robot @sethvargo @mikehelmick