This repository was archived by the owner on Jul 12, 2023. It is now read-only.
webview for user report initiation #2011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
sethvargo
suggested changes
Apr 8, 2021
pkg/controller/userreport/send.go
Outdated
| "github.com/gorilla/sessions" | ||
| ) | ||
|
|
||
| func stringFromSession(session *sessions.Session, key string) (string, error) { |
There was a problem hiding this comment.
See comment above, please move into pkg/controller/session.go
sethvargo
reviewed
Apr 8, 2021
| </main> | ||
|
|
||
| <script type="text/javascript"> | ||
| {{if $currentRealm.RequireDate}} |
There was a problem hiding this comment.
Can we use requiredIf on the actual HTML element instead of relying on javascript here?
There was a problem hiding this comment.
the attribute is already there - eventually this will do server side validation too
dropped
pkg/controller/userreport/index.go
Outdated
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| ctx := r.Context() | ||
| logger := logging.FromContext(ctx).Named("userreport.HandleIndex") | ||
| logger.Infow("serving index") |
|
|
||
| authApp := controller.AuthorizedAppFromContext(ctx) | ||
| if authApp == nil { | ||
| controller.Unauthorized(w, r, c.h) |
There was a problem hiding this comment.
Suggested change
| controller.Unauthorized(w, r, c.h) | |
| controller.MissingAuthorizedApp(w, r, c.h) |
There was a problem hiding this comment.
this needs to stay unauthorized for now - again error handling along this path is a TODO
| return | ||
| } | ||
|
|
||
| nonce := controller.NonceFromContext(ctx) |
There was a problem hiding this comment.
Should you handle the case where nonce == "" ?
There was a problem hiding this comment.
this is fine for now
sethvargo
approved these changes
Apr 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1928
Proposed Changes
Release Note