This repository was archived by the owner on Jul 12, 2023. It is now read-only.
Cleanup e2e API keys that have existed for > 24 hours #2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The e2e-runner does self cleanup, but sometimes the job times out or fails. In those cases, there's no opportunity for cleanup and we gradually leak API keys over time. This introduces a function for getting the e2e-realm (if one exists), and adds a new task to the cleanup job to delete e2e keys that have existed for more than 24 hours.
googlebot
added
the
cla: yes
whaught
approved these changes
Apr 9, 2021
mikehelmick
added a commit
that referenced
this pull request
Apr 10, 2021
This reverts commit 94222c0.
mikehelmick
added a commit
that referenced
this pull request
Apr 10, 2021
mikehelmick
reviewed
Apr 10, 2021
|
|
||
| result := db.db. | ||
| Unscoped(). | ||
| Where("realm_id = ? AND created_at < ?", realm.ID, deleteBefore). |
There was a problem hiding this comment.
I think this should always leave the most recent in place
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e-runner does self cleanup, but sometimes the job times out or fails. In those cases, there's no opportunity for cleanup and we gradually leak API keys over time.
This introduces a function for getting the e2e-realm (if one exists), and adds a new task to the cleanup job to delete e2e keys that have existed for more than 24 hours.
Release Note