This repository was archived by the owner on Jul 12, 2023. It is now read-only.
Fix uses of time.Truncate #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
/hold PTAL despite the hold. |
sethvargo
approved these changes
Oct 16, 2020
| var stats []*AuthorizedAppStats | ||
| if err := db.db. | ||
| Model(&UserStats{}). | ||
| Model(&AuthorizedAppStats{}). |
There was a problem hiding this comment.
This feels like it was a different bug?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeremyfaller, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mikehelmick
reviewed
Oct 16, 2020
mikehelmick
reviewed
Oct 16, 2020
mikehelmick
reviewed
Oct 16, 2020
**** NB ***** This PR will be marked HOLD until all reviews requested on this PR give it an LGTM. If you want to HOLD this CL, please add yourself as reviewer, and mark yourself as NON-LGTM. **** /NB ***** PTAL. These are all references to Truncate that: `grep -R Truncate * | grep 24` returned, and I think all changes are correct. Please verify. Fixes google#848
jeremyfaller
force-pushed
the
issue_848
branch
from
e11d092 to
bdd7d43
Compare
|
/retest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**** NB *****
This PR will be marked HOLD until all reviews requested on this PR give
it an LGTM. If you want to HOLD this CL, please add yourself as
reviewer, and mark yourself as NON-LGTM.
**** /NB *****
PTAL. These are all references to Truncate that:
grep -R Truncate * | grep 24returned, and I think all changes are correct. Please verify.
Fixes #848