Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

Use text templates for emails (not-html) #899

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Use text templates for emails (not-html) #899

merged 3 commits into from
Oct 27, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Oct 27, 2020 •
edited
Loading

Proposed Changes

  • Switch emails to plaintext renderer

Release Note

Switch emails to plaintext renderer

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Oct 27, 2020
sethvargo
sethvargo suggested changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be wrapping the content in template.HTML instead, but, even then, template.HTML is stripping the = from URLs.

sethvargo
sethvargo approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/render/render.go

if _, err := tmpl.ParseFiles(path); err != nil {
return fmt.Errorf("failed to parse %s: %w", path, err)
if strings.HasSuffix(info.Name(), ".txt") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@whaught whaught changed the title escape in all of the email templates Use text templates for emails (not-html) Oct 27, 2020
@google-oss-robot google-oss-robot merged commit 89c6f1a into google:main Oct 27, 2020
@whaught whaught deleted the more-escaping branch October 27, 2020 21:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

1 more reviewer

@sethvargo sethvargo sethvargo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whaught @google-oss-robot @sethvargo