Configurable buffer sizes via CMake #2923
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
This PR has two 1-month old commits in it, should it be rebased? |
I created a feature branch from upstream/master. Not sure what happened. |
|
We changed our branch from master to main a few weeks ago. And your change should define default values in the code, not just in the build system. |
What do you mean; see above for the changes in Allocators.h and OpenGLDriver.cpp |
|
That's exactly my point, your change relies on defines being set by the build system, not something we want. You should at least have a series of |
|
Ah I see what you mean; I wasn’t sure if you wanted to have such an implementation. I’ll make the changes. |
|
The master branch has now been deleted to avoid further confusions. GitHub finally fixed the issue that was preventing us from getting rid of it. |
|
Your change still touches many files that are not related to your change. |
This feature allows us to specify the buffer sizes that are used in Allocators.h and OpenGLDriver.cpp. Quick fix for #2057 By increasing these buffers we can render more instances.